Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook 7: kernel usage is missing #204

Closed
jtpio opened this issue Jul 26, 2023 · 6 comments · Fixed by #206
Closed

Notebook 7: kernel usage is missing #204

jtpio opened this issue Jul 26, 2023 · 6 comments · Fixed by #206
Labels
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Jul 26, 2023

Description

With Notebook 7 the side panel shows "Kernel usage is missing".

Reproduce

  1. Open a new Notebook with Notebook 7
  2. Open the kernel usage side panel

image

Expected behavior

It should show kernel metrics like in JupyterLab:

image

Context

  • Notebook 7.0.0
  • jupyter-resource-usage main branch
@jtpio
Copy link
Member Author

jtpio commented Jul 26, 2023

cc @mahendrapaipuri if you are interested in taking a look maybe.

Looks like this is the last remaining issue before being able to make a 1.0.0 release that would be compatible with JupyterLab 4 and Notebook 7.

@mahendrapaipuri
Copy link
Contributor

Yes, I will have a look at it! Cheers!

@jtpio
Copy link
Member Author

jtpio commented Jul 26, 2023

Thanks!

@mahendrapaipuri
Copy link
Contributor

@jtpio I tried to look into it a bit yesterday but I am afraid that I am bit out of my depth here.

In the case of notebook interface, seems like the subscription here is not behaving as it should. The tracker is emitting the active kernel and connection to the slot notebookChangeCallback returns true as well. But, the callback notebookChangeCallback never gets executed. So, all the react hooks stay in undefined state.

Do you know where should I look into?

@jtpio
Copy link
Member Author

jtpio commented Jul 27, 2023

Thanks for looking into it 👍

This is strange, normally it should indeed react to the currentChanged signal of the notebook tracker (used in the Notebook 7 code base). Maybe it's an issue with the lifecycle of the component (registering the callbacks too late maybe).

@jtpio
Copy link
Member Author

jtpio commented Jul 28, 2023

I think #206 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants