-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot tests need porting to JupyterLab 4.0 (or replacing with galata) #961
Comments
Whops, this should not get closed. While #966 does solve a lot of the failures, the problem with hovering over tokens remains. |
As the other thing got merged, will hoist my comment here: Yep, as I've found over on the relatively-simple jupyterlab_robotmode, CM6 is a lot harder to reason about from outside the system. And trying to get DOM nodes back out across a JSON pipe is... not going to work so well. If one could get access to a node, it would be relatively simple to apply some junk to it (i kinda like the dataset stuff, as it's unlikely to conflict with anything visual), but the If we could get back some lookup tables for the CSS classes, this could... sorta work. I've seen some references to As we develop solutions to some of these problems, I'd love to integrate them into robotframework-jupyterlibrary, so we don't have to rebuild this stuff on every project... |
For hover we could also traverse the cursor along the line waiting for the hover indicator to show up. Then query for a span. We could use a heuristic of moving cursor 10px at a time left to right while in the middle of the line. We would need the same for jump to definition and rename. |
#978 fixes most of it, except for completer and ironically a test for Robot itself (pending MarketSquare/jupyterlab_robotmode#14) |
Since porting this extension to JupyterLab 4 with CodeMirror 6 (#949) the acceptance tests are no longer passing. A few things will require more work to get them to work, largely due to CM6.
title
, a property we were extensively exploiting in the tests; instead the title is stored in instance bound to the element, accessible by semi-privatecmView
attribute (element.cmView.mark.spec.diagnostic.message
).<span>
elements - instead multiple variables can be in the same DOM text node, which prevents the use of selectorsOne approach to solve these would be instrumenting CodeMirror to produce
title
and replacing its tokenizer for tests, but then we are not testing the real thing. Maybe we could usearia-label
instead of title to also improve accessibility? Related CM discussions:The text was updated successfully, but these errors were encountered: