From d3c9ca0b5ce62e6fe62ca2c6ccf3aece0289243b Mon Sep 17 00:00:00 2001 From: James M Snell Date: Sat, 25 Feb 2017 22:52:16 -0800 Subject: [PATCH] fs: avoid using forEach PR-URL: https://github.com/nodejs/node/pull/11582 Reviewed-By: Matteo Collina Reviewed-By: Colin Ihrig --- lib/fs.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/fs.js b/lib/fs.js index 8a028bf79943e7..6487d39e4814d6 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -248,10 +248,11 @@ function statsFromValues() { } // Don't allow mode to accidentally be overwritten. -['F_OK', 'R_OK', 'W_OK', 'X_OK'].forEach(function(key) { - Object.defineProperty(fs, key, { - enumerable: true, value: constants[key] || 0, writable: false - }); +Object.defineProperties(fs, { + F_OK: {enumerable: true, value: constants.F_OK || 0}, + R_OK: {enumerable: true, value: constants.R_OK || 0}, + W_OK: {enumerable: true, value: constants.W_OK || 0}, + X_OK: {enumerable: true, value: constants.X_OK || 0}, }); function handleError(val, callback) {