Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive unnecessary calls to updateUrl on AppInner.componentDidUpdate #1368

Closed
jumpinjackie opened this issue Dec 15, 2021 · 0 comments
Closed

Excessive unnecessary calls to updateUrl on AppInner.componentDidUpdate #1368

jumpinjackie opened this issue Dec 15, 2021 · 0 comments
Assignees
@jumpinjackie
Labels
bug
Milestone
0.14.5

Comments

@jumpinjackie
Copy link
Owner

This is causing issues on Firefox where excessive calls to history/location APIs (that updateUrl wraps) will put Firefox into a state where subsequent calls will trigger a SecurityError: The operation is insecure error.

The fix is two pronged:

  1. Do not call updateUrl if the new computed state is not different than the previous one
  2. Debounce the actual history/location APIs calls within updateUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumpinjackie jumpinjackie

Labels
bug
Projects
None yet
Milestone
0.14.5
Development

No branches or pull requests
1 participant
@jumpinjackie