Migrate components to React hooks and use new context API #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt with useState() hooks cannot have its state inspected. The guidance around testing such components is to observe the side-effects of internal state change. In the case of the Accordion, we should be testing that the panel change handler is being invoked with the correct panel id.
…it as TypeScript 3.7 optional chaining renders this module obsolete.
…enzyme tests fail.
…egend components, replace the our legacy React contexts with the new React context API. Fixes #1014
…Panel unit tests (again, can't peek state of a hook-ed component, should instead verify the expected effects of the state change)
…rray content differences which we can simply do ourselves by just looping through both arrays if they happen to both be the same size and testing for item differences at the same position.
…log. Also tidy up UI and plug another localization hole in the ShareLinkToView component. Fixes #1012
…to hooks (these either use incompatible usage patterns of setState() or are going to be eventually replaced/rewritten anyways).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934, #1014 and #1015