Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: parallel mod (paratest, pest --parallel) fail erratically and inconsistently (and worse with JIT) #166

Open
julien-boudry opened this issue Jul 12, 2023 · 3 comments
Assignees
Labels

Comments

@julien-boudry
Copy link
Owner

Q A
Type Bug
Condorcet version *
PHP version ?
ENV *?
Installation Method Composer

Describe the bug
Tests fail erratically and inconsistently when run in parallel mode (various libraries), can be different fails at each run, and even worse with JIT enabled.
Look to be a PHP or test libraries bug due to the complexity of Condorcet.

To Reproduce
composer require --dev brianium/paratest
vendor/bin/paratest

(same with pest --parallel)

Expected behavior
No error, like without parallel.

@julien-boudry julien-boudry self-assigned this Jul 12, 2023
@julien-boudry
Copy link
Owner Author

@toddy15 This one is funny

@LiamM32
Copy link
Collaborator

LiamM32 commented Jul 14, 2023

Is this related to this issue? After my commit to the 'Experimental/Schulze-STV' branch, some tests pass when run individually, but fail when running composer test.

@julien-boudry
Copy link
Owner Author

julien-boudry commented Jul 14, 2023

No, this one is more about extraordinary and absurd (some of them not predictable between each runs) compilation errors. The first and iconic bug is that breaks class loader (with the correct use statement).

Parallel test and Jit compilation are experimental (tierce libraries and less know libraries, recent features...) in the PHP ecosystem. Condorcet work very well with non-parallel tests, and very well with (all ?) JIT compilation options. But not with parallel test (and worse if parallel + JIT).
This ticket is more about bugs in PHP and test libraries than Condorcet. (in the past, Condorcet was one of the first to find some news bugs with JIT compilation after public release of this recent PHP feature).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants