-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
messaging #10
Comments
yeah, according to http://caniuse.com/usage-table IEs<9 make up only 0.6% of the browser marker. I'd be down with publishing a new major with the deprecation warning...just so we don't annoy the ecosystem of modules already depending on this, but don't encourage any new modules written to use this. sounds good? |
Sounds great! |
@juliangruber I would recommend against deprecating. People may use this module for reasons other than just as a polyfill. For example, because they prefer a) a more functional approach, b) an approach more amenable to proxying during tests, and c), more generally, dependency injection over globals. |
@kgryte I think that extends past the scope and general use of this package. I suspect folks grab for things like |
@jdalton Without any statistics to back up your claim regarding general use, that is your opinion. I use this module and others like it for the reasons I mentioned earlier and I am fully aware that |
@kgryte You can always use v1 of this package. |
I'm with @jdalton here, |
@jdalton should we deprecate in code or in npm? I feel like npm is cleaner. |
@kgryte I agree with you, in my case I like a more functional approach. And I put this part of package in util. In my case I need support of IE < 9. You can check it out the util version that I use here. From now on(if the project dont need old browsers :D), I would use |
The npm route 👍 . In my mind it would be a combo of an up front readme notice and an npm deprecate message. That said, I guess the code could be simplified to |
Published |
🤘 I'll deprecate lodash.isarray too! |
Hi @juliangruber!
With IE < 11 no longer supported by MS & IE 8 being the last browser that needed
Array.isArray
would you be up for adding a npm deprecate message encouraging folks to useArray.isArray
?The text was updated successfully, but these errors were encountered: