Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/bench: add -p/--threads options to run benchmarks in parallel #545

Merged
merged 3 commits into from
Jun 22, 2021
Merged

cmd/bench: add -p/--threads options to run benchmarks in parallel #545

merged 3 commits into from
Jun 22, 2021

Conversation

SandyXSD
Copy link
Contributor

close #357

@chnliyong
Copy link
Contributor

Is -p(parallel) for short more suitable(-t may intuitively means test). In addition, sync sub command also use -p for short (--threads for long option), keep the option name consistent.

@SandyXSD SandyXSD changed the title cmd/bench: add -t/--threads options to run benchmarks in parallel cmd/bench: add -p/--threads options to run benchmarks in parallel Jun 22, 2021
@SandyXSD SandyXSD requested a review from davies June 22, 2021 02:06
davies
davies requested changes Jun 22, 2021
View reviewed changes
@davies davies merged commit 12223b2 into main Jun 22, 2021
@davies davies deleted the wip-bench branch June 22, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies davies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run benchmark in parallel
3 participants
@SandyXSD @chnliyong @davies