Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pod pvs to list mound pods #857

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

zxh326
Copy link
Member

@zxh326 zxh326 commented Jan 23, 2024

fix: #854

  • Remove pod mount pods annotation
  • Use pods pvs to list mount pods in dashboard pods api

Signed-off-by: Zzde <zhangxh1997@gmail.com>
@zxh326 zxh326 requested review from Hexilee, davies and timfeirg January 23, 2024 09:53
@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c1bebcb) 29.20% compared to head (8313922) 29.26%.

Files Patch % Lines
pkg/dashboard/pod.go 0.00% 7 Missing ⚠️
pkg/juicefs/mount/pod_mount.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   29.20%   29.26%   +0.06%     
==========================================
  Files          46       46              
  Lines        5654     5641      -13     
==========================================
  Hits         1651     1651              
+ Misses       3842     3829      -13     
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 1496003 into master Jan 23, 2024
24 checks passed
@davies davies deleted the use-pv-to-list-mountpods branch January 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] long namespace is not supported
3 participants