Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support injecting mountOptions by Node metadata #844

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Jan 2, 2024

In #759 , we supported injecting mountOptions by PVC metadata.

This PR supports injecting mountOptions by Node metadata.

Signed-off-by: xixi <hexilee@juicedata.io>
Signed-off-by: xixi <hexilee@juicedata.io>
Signed-off-by: xixi <hexilee@juicedata.io>
Signed-off-by: xixi <hexilee@juicedata.io>
@Hexilee Hexilee requested a review from davies January 2, 2024 08:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (c620a3c) 29.57% compared to head (da0068d) 29.58%.

Files Patch % Lines
pkg/util/pvc.go 46.66% 16 Missing ⚠️
pkg/driver/provisioner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #844   +/-   ##
=======================================
  Coverage   29.57%   29.58%           
=======================================
  Files          45       45           
  Lines        5562     5578   +16     
=======================================
+ Hits         1645     1650    +5     
- Misses       3757     3768   +11     
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xixi <hexilee@juicedata.io>
@davies davies merged commit 87fb2de into master Jan 5, 2024
22 of 23 checks passed
@davies davies deleted the xixi/support-node-inject branch January 5, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants