Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix app pod label and annotation when using multi pvcs #732

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Aug 30, 2023

fix #728

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (4a5b74f) 38.25% compared to head (0c4d648) 38.15%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   38.25%   38.15%   -0.11%     
==========================================
  Files          33       33              
  Lines        4078     4089      +11     
==========================================
  Hits         1560     1560              
- Misses       2371     2382      +11     
  Partials      147      147              
Files Changed Coverage Δ
pkg/controller/pod_controller.go 0.00% <0.00%> (ø)
pkg/juicefs/mount/pod_mount.go 34.54% <0.00%> (-0.19%) ⬇️
pkg/k8sclient/client.go 15.17% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwwhdls zwwhdls force-pushed the fix/app_annotation branch 3 times, most recently from 76d1da6 to 4d85bd5 Compare August 31, 2023 09:20
Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io>
@zwwhdls zwwhdls force-pushed the fix/app_annotation branch from 4d85bd5 to 1d18592 Compare August 31, 2023 10:21
Signed-off-by: zwwhdls <weiwei.zhu@juicefs.io>
@zwwhdls zwwhdls requested a review from Hexilee September 1, 2023 03:39
@zwwhdls zwwhdls merged commit bab665a into master Sep 6, 2023
@zwwhdls zwwhdls deleted the fix/app_annotation branch September 6, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] application pod annotation does not contain all mountpod when using mutil pvc
3 participants