Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix if pod namespace is empty && fix pod using multiple juicefs pvc #645

Merged
merged 16 commits into from
May 19, 2023

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Apr 24, 2023

close #644

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage: 34.10% and project coverage change: +0.26 🎉

Comparison is base (2e4a2b6) 40.85% compared to head (673974e) 41.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   40.85%   41.11%   +0.26%     
==========================================
  Files          32       31       -1     
  Lines        3598     3648      +50     
==========================================
+ Hits         1470     1500      +30     
- Misses       1989     2006      +17     
- Partials      139      142       +3     
Impacted Files Coverage Δ
pkg/juicefs/mount/builder/common.go 46.19% <ø> (ø)
pkg/k8sclient/client.go 16.34% <0.00%> (-1.01%) ⬇️
pkg/webhook/handler/config/volume.go 32.46% <32.46%> (ø)
pkg/webhook/handler/mutate/sidecar.go 25.00% <47.50%> (+11.20%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwwhdls zwwhdls marked this pull request as ready for review May 6, 2023 03:47
@Hexilee Hexilee self-requested a review May 8, 2023 05:12
Copy link
Contributor

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@zwwhdls zwwhdls merged commit c38b68d into master May 19, 2023
@zwwhdls zwwhdls deleted the fix/webhook branch May 19, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] sidecar can not be injected in CCE
3 participants