Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Plea: keep "use_username_in_magic_dns" even after tags are fixed #2213

Closed
2 tasks
noseshimself opened this issue Oct 25, 2024 · 6 comments
Closed
2 tasks
Labels
enhancement New feature or request

Comments

@noseshimself
Copy link

Use case

We do have a sufficient number of identical host names that have been personalized based on user names as intermediate components in DNS names. This has become necessary after deciding that we will be giving up centralized offices AND a number of centralized IT services during the Covid lockdown phase. One of the tools enabling us to do so was being able to use unqualified host names and having magicDNS do the job. Now you're pulling the rug under our lazy asses away.

Description

Keep "use_username_in_magic_dns" if it is possible at all.

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

Just don't delete what is necessary. The flag "use_username_in_magic_dns" can be used to turn it off as default setting and those who really need it can continue using it.

@noseshimself noseshimself added the enhancement New feature or request label Oct 25, 2024
@celevra
Copy link

celevra commented Nov 13, 2024

we use them also to organize "group" of hosts.
it is a great feature! So please keep it

@juanfont
Copy link
Owner

Sorry, this was my bad.

It was never ment to be added in the first place and it will not be added back, the goal of this project is to align with Tailscale.

@celevra
Copy link

celevra commented Nov 19, 2024

this could be a optional feature
So in the default configuration you are fully compatible to tailscale
but for us it is a killer feature.
All our logic is based on it, so that we need a way to build it, if you really remove it (why remove a working feature?).
than we need a webhook for new devices and create custom dns entries...

@noseshimself
Copy link
Author

we need a webhook for new devices and create custom dns entries...

I don't think that will be sufficient unless you can override Magic DNS with another source based on that source's answer (if it is providing a CNAME or A/AAAA, fine but if there is a negative answer coming back it has to try Magic-ing. On receiving a CNAME it you need to add even more checks. It's a nightmare.

@kradalby
Copy link
Collaborator

I will add a way for you to programatically provide the DNS server with new entries, see #2262.

We will not reintroduce the feature, it is not a fully working feature and it is not safe.

@celevra
Copy link

celevra commented Nov 29, 2024

Awesome!
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants