From df3a2589175308d7c0391f23ca72073537a6a86b Mon Sep 17 00:00:00 2001 From: JordiSubira Date: Tue, 12 Jan 2021 17:11:11 +0100 Subject: [PATCH] unify personal annotations to JordiSubira (#80) Only comments modified. --- go/pkg/cs/drkey/grpc/lvl1_exchange_test.go | 2 +- go/pkg/cs/drkey/prefetcher.go | 2 +- go/pkg/cs/drkey/secret_value_store.go | 2 +- go/pkg/trust/transport_credentials.go | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/go/pkg/cs/drkey/grpc/lvl1_exchange_test.go b/go/pkg/cs/drkey/grpc/lvl1_exchange_test.go index e34d1ceb9e..4a2e909556 100644 --- a/go/pkg/cs/drkey/grpc/lvl1_exchange_test.go +++ b/go/pkg/cs/drkey/grpc/lvl1_exchange_test.go @@ -118,7 +118,7 @@ func TestLvl1KeyFetching(t *testing.T) { require.NoError(t, err) } -// XXX(jordiSubira) TestLvl1KeyFetching below checks correct Lvl1 key exchange as from Go1.15 +// XXX(JordiSubira) TestLvl1KeyFetching below checks correct Lvl1 key exchange as from Go1.15 // which introduces VerifyConnection callback to access TLS state during handshake. // func TestLvl1KeyFetching(t *testing.T) { diff --git a/go/pkg/cs/drkey/prefetcher.go b/go/pkg/cs/drkey/prefetcher.go index 037ccf6521..fa4d9e8551 100644 --- a/go/pkg/cs/drkey/prefetcher.go +++ b/go/pkg/cs/drkey/prefetcher.go @@ -32,7 +32,7 @@ var _ periodic.Task = (*Prefetcher)(nil) type Prefetcher struct { LocalIA addr.IA Store drkeystorage.ServiceStore - // XXX(jonieto): At the moment we assume "global" KeyDuration, i.e. + // XXX(JordiSubira): At the moment we assume "global" KeyDuration, i.e. // every AS involved uses the same EpochDuration. This will be improve // further in the future, so that the prefetcher get keys in advance // based on the epoch established by the AS which derived the first diff --git a/go/pkg/cs/drkey/secret_value_store.go b/go/pkg/cs/drkey/secret_value_store.go index cabc2c32c8..b6d6824615 100644 --- a/go/pkg/cs/drkey/secret_value_store.go +++ b/go/pkg/cs/drkey/secret_value_store.go @@ -26,7 +26,7 @@ import ( // SecretValueStore keeps the current and next secret values and removes the expired ones. type SecretValueStore struct { - // TODO(jordiSubira): simplify class to be more consistent with keeping current and next + // TODO(JordiSubira): simplify class to be more consistent with keeping current and next // secret values. cache map[int64]drkey.SV mutex sync.Mutex diff --git a/go/pkg/trust/transport_credentials.go b/go/pkg/trust/transport_credentials.go index 6fe73a2926..9e4800c107 100644 --- a/go/pkg/trust/transport_credentials.go +++ b/go/pkg/trust/transport_credentials.go @@ -27,7 +27,7 @@ import ( "github.com/scionproto/scion/go/lib/serrors" ) -// XXX(jordiSubira): ClientCredentials enables hooking a procedure to validate +// XXX(JordiSubira): ClientCredentials enables hooking a procedure to validate // the TLS state during the client handshake. Note that the current implementation // extends the grpc/credentials callback for TLS credentials by carrying out the // validation after the handshake has been completed (this last using the provided @@ -69,7 +69,7 @@ func (c *ClientCredentials) ClientHandshake(ctx context.Context, authority strin "authInfoType", authInfo.AuthType()), } } - // XXX (jonito): In Go1.13 tls.ConnectionState.ServerName is only set + // XXX (JordiSubira): In Go1.13 tls.ConnectionState.ServerName is only set // on the server side. Thus, we pass authority as the serverName. if err = verifyConnection(tlsInfo.State, authority); err != nil { conn.Close()