Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and maven build on Java 1.8 #17

Open
ecky-l opened this issue Apr 29, 2016 · 1 comment
Open

Fix tests and maven build on Java 1.8 #17

ecky-l opened this issue Apr 29, 2016 · 1 comment

Comments

@ecky-l
Copy link

ecky-l commented Apr 29, 2016

I try to compile Jtcl on Java 1.8 with maven. The issue applies to both, release and latest github repo on windows 7 (Oracle JDK-1.8) and linux (openjdk-1.8).

First thing I get:
"""
INFO] --- exec-maven-plugin:1.2:exec (gensource) @ jtcl ---
javac: target release 1.5 conflicts with default source release 1.8
jdk tool check failed: JAVAC not working
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
"""
Obviously I stumble over the "-g -target 1.5" definition in src/main/resources/tcl/pkg/tjc/library/jdk.tcl line 252:

set javac_flags "-g -target 1.5"

I changed that to be

set javac_flags "-g"

Now the code compiles, and even the maven-exec plugin with tjc works, and compiles seemingly.
But then many of the tests fail and maven does not continue because of the failed tests. The output is too long for pasting it here...

Are the failing tests due to the now missing "-target 1.5"? If so: wouldn't it make sense to drop support for the far outdated Java 1.5 in favor of supporting more modern Java versions?

@nkluge
Copy link

nkluge commented Dec 19, 2016

Same issue here. Thanks @ecky-l for this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants