Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the helm chart? #277

Closed
davidkarlsen opened this issue Aug 8, 2020 · 19 comments · Fixed by #287
Closed

Adopt the helm chart? #277

davidkarlsen opened this issue Aug 8, 2020 · 19 comments · Fixed by #287

Comments

@davidkarlsen
Copy link

Please see https://github.com/helm/charts/issues/21103
The helm stable repo is about to shut down.
Would you be interested in maintaining the chart here?
We have tooling like shown in https://github.com/helm/charts-repo-actions-demo to support a workflow for testing and releasing charts. Visibility on the Helm Hub is done through https://github.com/helm/hub
CC @scottrigby

@scottrigby
Copy link
Contributor

Note that Nov 13, 2020 the stable repo will be unsupported.

@mariusv
Copy link
Collaborator

mariusv commented Sep 14, 2020

@davidkarlsen if nobody is interested I can pick this one up and maintain it as I'm using it on a daily basis on about 10 clusters CC @scottrigby

@scottrigby
Copy link
Contributor

I just pinged @jtblin on Slack and by email in case this was missed. One note: if @jtblin agrees to host it under their github username just like the project is, the chart could be marked "official" in the CNCF Artifact Hub https://artifacthub.io/

@jtblin
Copy link
Owner

jtblin commented Sep 15, 2020

Yes I'm happy to host it, however I do not have much time to maintain it so I'd love to enlist @mariusv help for that.

@mariusv
Copy link
Collaborator

mariusv commented Sep 16, 2020

Awesome, I'll do a PR with the chart and add it to the chart directory ? Or you prefer any other path @jtblin ?

@scottrigby
Copy link
Contributor

scottrigby commented Sep 18, 2020

@mariusv I would suggest following similar steps as I did for the prometheus-community charts: prometheus-community/helm-charts#3 (this brings git history into your repo). For directory, /charts is a good choice if you have no reason to change it (this is the default for chart-testing).

Then, as @davidkarlsen said in #277 (comment) you can emulate the GitHub Actions in the demo repo for CI/CD. If you'd like help with that please let me know 😄

@jtblin
Copy link
Owner

jtblin commented Sep 19, 2020

Awesome, I'll do a PR with the chart and add it to the chart directory ? Or you prefer any other path @jtblin ?

@mariusv PR is great 👍

@benfrench1
Copy link

Hi @jtblin and @mariusv , hope you are well.
I have a silly question....where is the proposed new location for the kube2iam helm chart? Can you post the link please, that would be much appreciated 😄.
Many thanks

@denniswebb
Copy link
Contributor

@jtblin I'm open to doing the PR for the chart. Where were you planning on hosting the packaged chart? Just a GitHub pages site?

@dan-slinky-ckpd
Copy link

Any update on this? As per the deprecation timeline, the chart repos will likely be garbage collected and no longer available from Friday 13th November 2020 - happy to help contribute.

@mariusv mariusv mentioned this issue Nov 12, 2020
@mariusv
Copy link
Collaborator

mariusv commented Nov 12, 2020

@dan-slinky-ckpd PR is here. We need @jtblin to create the Github pages to be able to host the chart

@mariusv
Copy link
Collaborator

mariusv commented Nov 12, 2020

@jtblin I can enable github pages on my fork if you want but I guess you'd rather do this under this repo

@zhimsel
Copy link

zhimsel commented Nov 13, 2020

This should be reopened. The chart itself was migrated here, but there is no repo yet set up to host it.

@mariusv
Copy link
Collaborator

mariusv commented Nov 13, 2020

@zhimsel good catch. Added a new PR to fix the README issues #289

@mariusv
Copy link
Collaborator

mariusv commented Nov 13, 2020

@jtblin could you please enable Github Pages so I can push the chart in there? I can also enable it on my repo but would rather have it here

@mariusv
Copy link
Collaborator

mariusv commented Nov 13, 2020

@jtblin this is what needs to be done

@benfrench1
Copy link

Is there any update on this :)

@jtblin
Copy link
Owner

jtblin commented Dec 21, 2020

Ok, I've completed the configuration and triggered a release event. It seems to have created http://jtblin.github.io/kube2iam/index.yaml, is that all that's needed?

@chadlwilson
Copy link

Thanks a lot @jtblin - it seems to be working via helm fetch kube2iam --repo http://jtblin.github.io/kube2iam so I guess updating the README and such for a new version via #289 is all that is required here now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants