Add additional failure test

jsx-eslint · Jan 12, 2016 · ce330d8 · ce330d8
1 parent 4ab1b3e
commit ce330d8
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 3 deletions.
diff --git a/lib/rules/jsx-sort-prop-types.js b/lib/rules/jsx-sort-prop-types.js
@@ -77,8 +77,8 @@ module.exports = function(context) {
         }
         if (!previousIsRequired && currentIsRequired) {
           // Encountered a non-required prop after a required prop
-          context.report(prev, 'Required prop types must be listed before all other prop types');
-          return prev;
+          context.report(curr, 'Required prop types must be listed before all other prop types');
+          return curr;
         }
       }
 

diff --git a/tests/lib/rules/jsx-sort-prop-types.js b/tests/lib/rules/jsx-sort-prop-types.js
@@ -534,6 +534,29 @@ ruleTester.run('jsx-sort-prop-types', rule, {
       column: 5,
       type: 'Property'
     }]
+  }, {
+    code: [
+      'var First = React.createClass({',
+      '  propTypes: {',
+      '    fooRequired: React.PropTypes.string.isRequired,',
+      '    barRequired: React.PropTypes.string.isRequired,',
+      '    a: React.PropTypes.any',
+      '  },',
+      '  render: function() {',
+      '    return <div />;',
+      '  }',
+      '});'
+    ].join('\n'),
+    options: [{
+      requiredFirst: true
+    }],
+    parserOptions: parserOptions,
+    errors: [{
+      message: ERROR_MESSAGE,
+      line: 4,
+      column: 5,
+      type: 'Property'
+    }]
   }, {
     code: [
       'var First = React.createClass({',
@@ -553,7 +576,7 @@ ruleTester.run('jsx-sort-prop-types', rule, {
     parserOptions: parserOptions,
     errors: [{
       message: 'Required prop types must be listed before all other prop types',
-      line: 3,
+      line: 4,
       column: 5,
       type: 'Property'
     }]