Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-has-lang rule seems redundant with lang #777

Closed
denis-sokolov opened this issue Mar 2, 2021 · 0 comments · Fixed by #778
Closed

html-has-lang rule seems redundant with lang #777

denis-sokolov opened this issue Mar 2, 2021 · 0 comments · Fixed by #778

Comments

@denis-sokolov
Copy link
Contributor

The rule html-has-lang is fully superseded by the lang rule. Would we consider marking the former as deprecated in favor of the latter one?

As I was reviewing the list of rules, I got confused and had to figure out whether I misunderstood something. Having one marked as deprecated would really help. I don’t see any particular reason for html-has-lang to exist. Alternatively, if there is an important case that I miss, we could add explanation to the docs as to the similarity of the two.

Related: #750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Docs] Document the similarity between html-has-lang and lang denis-sokolov/eslint-plugin-jsx-a11y
1 participant
@denis-sokolov