Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peerDependency on eslint #62

Closed
ljharb opened this issue Jul 2, 2016 · 8 comments
Closed

Add peerDependency on eslint #62

ljharb opened this issue Jul 2, 2016 · 8 comments

Comments

@ljharb
Copy link
Member

ljharb commented Jul 2, 2016

Since this package implicitly depends on eslint, it should be a peer dep.

@beefancohen
Copy link
Contributor

Thanks, fixed in v1.5.4

@ljharb
Copy link
Member Author

ljharb commented Jul 6, 2016

@evcohen thanks - could you also add || 3.x so that it works with eslint 3?

@beefancohen
Copy link
Contributor

Done! v1.5.5

@ryanvanoss
Copy link
Contributor

ryanvanoss commented Jul 20, 2016

@evcohen, that should have been a major bump, or included 1.x -- what used to work when using eslint@^1.0.0 now fails due to the explicit peer dependency declaration. I thought I taught you better ;)

Don't worry, we're updating anyway :)

@ljharb
Copy link
Member Author

ljharb commented Jul 20, 2016

I'd have thought it'd have failed on eslint v1 a long time ago - indeed that would make it a major bump, even though nobody should still be on v1 ;-)

@ryanvanoss
Copy link
Contributor

@ljharb, yep, it would have if we had been working on the old repo -- just picked up some old work from the end of last year. Definitely time to upgrade.

@beefancohen
Copy link
Contributor

miss you @ryanvanoss
glad i can still create bugs for you guys 😜

@ryanvanoss
Copy link
Contributor

@evcohen we never doubted. Thanks for living up to expectations :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants