We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This can happen, for instance, if the underlying transformer only supports render.
render
It will throw synchronously when calling it.
A simple solution would be to wrap all calls to the jstransformer in a try-catch.
What do you think?
More thoughts:
It's bad that renderAsync can do that because other modules don't expect an async function to throw synchronously, e.g. (fix) add filename when jstransformer throws synchronously metalsmith/in-place#174
renderAsync
It's not an issue with the underlying jstransformer because it supports render which can throw synchronously.
The text was updated successfully, but these errors were encountered:
Yes, we should wrap in a try catch to handle synchronous errors. I'd be happy to accept a pull request for this.
Sorry, something went wrong.
No branches or pull requests
This can happen, for instance, if the underlying transformer only supports
render
.It will throw synchronously when calling it.
A simple solution would be to wrap all calls to the jstransformer in a try-catch.
What do you think?
More thoughts:
It's bad that
renderAsync
can do that because other modules don't expect an async function to throw synchronously, e.g. (fix) add filename when jstransformer throws synchronously metalsmith/in-place#174It's not an issue with the underlying jstransformer because it supports
render
which can throw synchronously.The text was updated successfully, but these errors were encountered: