Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Throttle warning #18

Closed
MScottBlake opened this issue Dec 5, 2014 · 3 comments
Closed

Enhancement: Throttle warning #18

MScottBlake opened this issue Dec 5, 2014 · 3 comments

Comments

@MScottBlake
Copy link

I'm getting hit with this warning twice per recipe and while I understand the importance of displaying it, the level of spam makes it difficult to pick out relevant error messages. Is there any way it can be set to only display it once in a single Autopkg run and hide the rest?

/Library/Python/2.7/site-packages/python_jss-0.5.2-py2.7.egg/jss/contrib/requests/packages/urllib3/connection.py:251: SecurityWarning: Certificate has no `subjectAltName`, falling back to check for a `commonName` for now. This feature is being removed by major browsers and deprecated by RFC 2818. (See https://github.com/shazow/urllib3/issues/497 for details.)
  SecurityWarning
@sheagcraig
Copy link
Collaborator

@MitchelSBlake Indeed, a lot of requests go through, and to have each one throw a warning is pretty annoying. Without going into the implications of the warning itself, which I assume you can figure out on your own, there should be a way to disable the warnings entirely.

urllib3 has a disable_warnings method which should do it.

I'm preparing a release right now-let me drop in an optional input variable to cover this.

@sheagcraig
Copy link
Collaborator

I'll probably put it in python-jss and just let JSSImporter use it rather than set it directly itself.

@sheagcraig
Copy link
Collaborator

Done. Going into 0.3.5/python-jss v0.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants