Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs say port key, but python-jss seems to use share_port key #11

Closed
eahrold opened this issue Nov 8, 2014 · 1 comment
Closed

docs say port key, but python-jss seems to use share_port key #11

eahrold opened this issue Nov 8, 2014 · 1 comment

Comments

@eahrold
Copy link
Contributor

eahrold commented Nov 8, 2014

I've been testing out the custom DP feature and realized two discrepancies

the README.md in this project says "port" but python-jss seems to use "share_port"
https://github.com/sheagcraig/python-jss/blob/master/jss/distribution_points.py#L134

also key is "domain" but python-jss seems to use "workgroup_or_domain"
https://github.com/sheagcraig/python-jss/blob/master/jss/distribution_points.py#L132

I just wanted to touch base and see what your plans were so we can keep AutoPkgr in sync.

Thanks

@sheagcraig
Copy link
Collaborator

I see what's going on here.

So in the DistributionPoint results from the JSS, Jamf calls it "share_port" and "workgroup_or_domain", which is where those names came from. I was rushing to get stuff included while the baby was sleeping, so I neglected to correct these, and since they aren't required, it wasn't an issue.

Good eyes!

I would prefer they use the names that are documented, so I'll change the gets to use port and domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants