Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix php warning, docblocks, and peephole optimizations #659

Closed
wants to merge 5 commits into from
Closed

Fix php warning, docblocks, and peephole optimizations #659

wants to merge 5 commits into from

Commits on Mar 19, 2021

  1. fix phpdoc: missing typehints on $path and $value

    @robocoder
    robocoder committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    b5fd87e View commit details
    Browse the repository at this point in the history

  2. testing for !$isValid is redundant at this point

    @robocoder
    robocoder committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    f4b197f View commit details
    Browse the repository at this point in the history

  3. $path enters this function as JsonPointer instance

    @robocoder
    robocoder committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    a157dda View commit details
    Browse the repository at this point in the history

  4. add addSchema() unit test to trigger error when schema is missing "pr… 

    …operties"

```
There was 1 error:

1) JsonSchema\Tests\SchemaStorageTest::testMissingProperties
Creating default object from empty value

/Development/json-schema/src/JsonSchema/SchemaStorage.php:64
/Development/json-schema/tests/SchemaStorageTest.php:334
```
    @robocoder
    robocoder committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    46384b1 View commit details
    Browse the repository at this point in the history

  5. fix php warning

    @robocoder
    robocoder committed Mar 19, 2021
    Configuration menu
    Copy the full SHA
    fbf27f5 View commit details
    Browse the repository at this point in the history