Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clousure compiler warnings #145

Open
Ognian opened this issue Oct 10, 2014 · 1 comment
Open

clousure compiler warnings #145

Ognian opened this issue Oct 10, 2014 · 1 comment

Comments

@Ognian
Copy link
Contributor

Ognian commented Oct 10, 2014

I'm using my new grunt knowledge to squeeze jsonary thru googles closure compiler.
Although everything looks good and the resulting jsonary works good, I'm getting 4 warnings which I think are worth to look into:

Compiling public/src/jsonary/node-package/core/jsonary-core.js,public/src/jsonary/renderers/plain.jsonary.js,public/src/jsonary/renderers/string-formats.js,public/src/lims/lims_jsonary/markdown.js,public/src/lims/lims_jsonary/defaultJSFunction.js,public/src/lims/lims_jsonary/csv-file-picker.js,public/src/jsonary/renderers/contributed/x-display-order.js,public/src/jsonary/plugins/jsonary.render.generate.js,public/src/jsonary/plugins/jsonary.render.table.js,public/src/jsonary/renderers/contributed/adaptive-table.js,public/src/jsonary/renderers/contributed/validation.js,public/src/jsonary4lims/jsonary4lims.js -> public/shared/jsonary4lims/compiled.js
>> public/src/jsonary/node-package/core/jsonary-core.js:1987: WARNING - unreachable code
>>          if (timeLimit == undefined) {
>>          ^
>> 
>> public/src/jsonary/node-package/core/jsonary-core.js:3065: WARNING - Suspicious code. This code lacks side-effects. Is there a bug?
>>                      if (basicType == "object") {
>>                      ^
>> 
>> public/src/jsonary/node-package/core/jsonary-core.js:6143: WARNING - unreachable code
>>          for (var i = 0; i < candidates.length; i++) {
>>                                                 ^
>> 
>> public/src/jsonary/node-package/core/jsonary-core.js:6365: WARNING - Suspicious code. The result of the 'eq' operator is not being used.
>>              origValue == origValue.value();
>>              ^
>> 
>> 0 error(s), 4 warning(s)
>> Complete: 188617
@geraintluff
Copy link
Contributor

Thanks, I'll have a look at these - some of them do indeed look suspicious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants