Skip to content

re-unite meta-schema #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2025
Merged

re-unite meta-schema #1610

merged 5 commits into from
Jul 19, 2025

Conversation

gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Jun 22, 2025

What kind of change does this PR introduce?

Refactor

Issue & Discussion References

Summary

Re-unites the meta-schema into a single file since vocabularies are a proposal now. We will likely split it back up again when we figure out vocabs, but for now it doesn't make sense to have them separated.

Also:

  • removes any deprecated keywords
  • reserves the names of existing proposals
  • reserves x-* keywords
  • reserves $* keywords

Does this PR introduce a breaking change?

@gregsdennis gregsdennis marked this pull request as ready for review June 22, 2025 04:49
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this work.
Left one comment, but not essential.

Copy link
Member

@jviotti jviotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gregsdennis
Copy link
Member Author

@jdesrosiers I've updated the $-keyword restriction using your suggestion. It's a bit direct, but simple is probably better anyway.

@gregsdennis gregsdennis merged commit e929dbc into main Jul 19, 2025
6 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/meta-schema branch July 19, 2025 05:49
@github-project-automation github-project-automation bot moved this from In Progress to Done in Stable Release Development Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Reunite the meta-schemas Unsupported deprecated keywords are listed in the metaschema
7 participants