From 8ba1c90dc62b9ddd6c2efc2c395d122a8d68135d Mon Sep 17 00:00:00 2001 From: Jason Desrosiers Date: Fri, 27 Oct 2023 12:25:17 -0700 Subject: [PATCH] Update unevaluted with dynamic ref to be more likely to catch errors --- tests/draft2019-09/unevaluatedItems.json | 5 +++-- tests/draft2019-09/unevaluatedProperties.json | 5 +++-- tests/draft2020-12/unevaluatedItems.json | 3 ++- tests/draft2020-12/unevaluatedProperties.json | 3 ++- 4 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/draft2019-09/unevaluatedItems.json b/tests/draft2019-09/unevaluatedItems.json index 8750db29..9c115ab3 100644 --- a/tests/draft2019-09/unevaluatedItems.json +++ b/tests/draft2019-09/unevaluatedItems.json @@ -504,8 +504,9 @@ "items": [ { "type": "number" }, { - "$recursiveRef": "#", - "unevaluatedItems": false + "$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering", + "unevaluatedItems": false, + "$recursiveRef": "#" } ] } diff --git a/tests/draft2019-09/unevaluatedProperties.json b/tests/draft2019-09/unevaluatedProperties.json index 01acc215..4e0d3ec8 100644 --- a/tests/draft2019-09/unevaluatedProperties.json +++ b/tests/draft2019-09/unevaluatedProperties.json @@ -737,8 +737,9 @@ "properties": { "node": true, "branches": { - "$recursiveRef": "#", - "unevaluatedProperties": false + "$comment": "unevaluatedProperties comes first so it's more likely to bugs errors with implementations that are sensitive to keyword ordering", + "unevaluatedProperties": false, + "$recursiveRef": "#" } }, "required": ["node"] diff --git a/tests/draft2020-12/unevaluatedItems.json b/tests/draft2020-12/unevaluatedItems.json index fa8e2e88..ddc35da2 100644 --- a/tests/draft2020-12/unevaluatedItems.json +++ b/tests/draft2020-12/unevaluatedItems.json @@ -480,12 +480,13 @@ "baseSchema": { "$id": "/baseSchema", + "$comment": "unevaluatedItems comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering", + "unevaluatedItems": false, "type": "array", "prefixItems": [ { "type": "string" } ], "$dynamicRef": "#addons", - "unevaluatedItems": false, "$defs": { "defaultAddons": { diff --git a/tests/draft2020-12/unevaluatedProperties.json b/tests/draft2020-12/unevaluatedProperties.json index 84bdd716..023e84a5 100644 --- a/tests/draft2020-12/unevaluatedProperties.json +++ b/tests/draft2020-12/unevaluatedProperties.json @@ -733,12 +733,13 @@ "baseSchema": { "$id": "/baseSchema", + "$comment": "unevaluatedProperties comes first so it's more likely to catch bugs with implementations that are sensitive to keyword ordering", + "unevaluatedProperties": false, "type": "object", "properties": { "foo": { "type": "string" } }, "$dynamicRef": "#addons", - "unevaluatedProperties": false, "$defs": { "defaultAddons": {