Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cfg files need to be fixed and released #1558

Closed
dirk-thomas opened this issue Mar 21, 2016 · 1 comment
Closed

.cfg files need to be fixed and released #1558

dirk-thomas opened this issue Mar 21, 2016 · 1 comment

Comments

@dirk-thomas
Copy link

Recently you fixed some of the dynamic reconfigure files in this repo (b79ec0a1f8638a87aea774629e465cc38ef7bd94).Other files still need the same fix: e.g.

try:
import imp
imp.find_module(PACKAGE)
from dynamic_reconfigure.parameter_generator_catkin import *
except:
import roslib; roslib.load_manifest(PACKAGE)
from dynamic_reconfigure.parameter_generator import *
try:
import imp
imp.find_module(PACKAGE)
from dynamic_reconfigure.parameter_generator_catkin import *;
except:
import roslib; roslib.load_manifest(PACKAGE)
from dynamic_reconfigure.parameter_generator import *;

The fixes also need to be released. Currently the Jade jobs fail since the old code falls back to the non-catkin code generation which won't generate the header in the correct location.

This will likely also be the same for the upcoming Indigo rebuild.

@k-okada
Copy link
Member

k-okada commented Mar 22, 2016

Thanks, fixed in #1559

@k-okada k-okada closed this as completed Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants