Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.cfg files need to be fixed and released #57

Closed
dirk-thomas opened this issue Mar 20, 2016 · 2 comments
Closed

.cfg files need to be fixed and released #57

dirk-thomas opened this issue Mar 20, 2016 · 2 comments

Comments

@dirk-thomas
Copy link

The .cfg files in this repo need to be fixed the same as jsk-ros-pkg/jsk_common@b79ec0a. E.g. https://github.com/jsk-ros-pkg/jsk_3rdparty/blob/master/3rdparty/mini_maxwell/cfg/RosClient.cfg

These changes need to be released. Currently the Jade jobs fail since the old code falls back to the non-catkin code generation which won't generate the header in the correct location (e.g. http://build.ros.org/job/Jbin_uT64__mini_maxwell__ubuntu_trusty_amd64__binary/2/).

This will likely also be the same for the upcoming Indigo rebuild.
@dirk-thomas dirk-thomas mentioned this issue Mar 20, 2016
Merged
@k-okada
Copy link
Member

k-okada commented Mar 20, 2016

thanks, fixed in #58

@dirk-thomas
Copy link
Author

Thank you for the fast fix and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k-okada @dirk-thomas