Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lottie as zip #350

Closed
aminerol opened this issue Dec 13, 2024 · 4 comments
Closed

Lottie as zip #350

aminerol opened this issue Dec 13, 2024 · 4 comments

Comments

@aminerol
Copy link
Contributor

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch mime-db@1.52.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/mime-db/db.json b/node_modules/mime-db/db.json
index eb9c42c..4131489 100644
--- a/node_modules/mime-db/db.json
+++ b/node_modules/mime-db/db.json
@@ -6342,7 +6342,7 @@
   "application/zip": {
     "source": "iana",
     "compressible": false,
-    "extensions": ["zip"]
+    "extensions": ["zip", "lottie"]
   },
   "application/zlib": {
     "source": "iana"

This issue body was partially generated by patch-package.

@bjohansebas
Copy link
Member

Why should it be a lottie extension of applications/zip?

@aminerol
Copy link
Contributor Author

Lottie introduces this new format for performance purposes and its just a zip. this is from their doc website

dotLottie is an open-source file format that aggregates one or more Lottie files and their associated resources into a single file. They are ZIP archives compressed with the Deflate compression method and carry the file extension of ".lottie".

if you wanna read more about it https://dotlottie.io/intro/

@wesleytodd
Copy link
Member

related: #351

That PR resolves this correct?

@jonchurch
Copy link
Member

The pr is the preferred way to do this, adding a new mimetype.

There a lots of filetypes which are zip plus some structure, zip would be full of extension types if we took this approach.

@jonchurch jonchurch closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants