Skip to content
This repository has been archived by the owner on Feb 11, 2021. It is now read-only.

Does libgrabber verify if files are new? #41

Open
tomByrer opened this issue Nov 19, 2014 · 3 comments
Open

Does libgrabber verify if files are new? #41

tomByrer opened this issue Nov 19, 2014 · 3 comments

Comments

@tomByrer
Copy link
Contributor

I found a project that seemed to fail to upload the new files after bumping a new release. 2 clues:

  • file dates are 2 weeks old after the new 0.3.1
  • top-line comment still reads the old 0.3.0 version.

I'd think it would be nice to at least warn of old files, so our admins won't push a non-update update when they're multitasking.

@jimaek
Copy link
Member

jimaek commented Nov 19, 2014

I think its too much work for such rare cases

@lewisgoddard
Copy link

We could check for files identical to the previous release by using a checksum relatively easily, but it does seem like overkill for what I would presume is such a rare occurrence.

@tomByrer
Copy link
Contributor Author

check for files identical to the previous release

That works.
What happened in this case was the docs were changed, but not source, so he bumped the version anyhow. I can see someone bumping version for changing only dev dependencies also.
But yes, very uncommon case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants