Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New behaviour of S3 storage exists() breaks current workflow #1429

Closed
saemideluxe opened this issue Jul 9, 2024 · 2 comments
Closed

New behaviour of S3 storage exists() breaks current workflow #1429

saemideluxe opened this issue Jul 9, 2024 · 2 comments

Comments

@saemideluxe
Copy link

saemideluxe commented Jul 9, 2024

In our application, we allow overwriting large files on S3 (so, having file_overwrite=True). We were relying on the existing behavior of myfile.storage.exists(myfile.name) to render urls or a null-character. With the new check introduced in #1422 this behaviour breaks. The file has been generated and uploaded, but our template will not render the link, as it thinks the file does not exist.

Are we doing the check for exists wrong? I am happy to fix my own code, but in case this is an unforeseen side effect of #1422 I would like to report it here.

Also, thanks for all your work on this library, it makes working with S3 very easy!

@violuke
Copy link

violuke commented Jul 9, 2024

This will break things for anyone (like me) using django-health-check.

@jschneier
Copy link
Owner

Let's centralize discussion on #1430. Thanks for opening and apologies. I've posted my reasoning there but am open to reverting.

@jschneier jschneier closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants