Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace conflict with djangular #11

Closed
fladi opened this issue Jan 29, 2014 · 4 comments
Closed

Namespace conflict with djangular #11

fladi opened this issue Jan 29, 2014 · 4 comments

Comments

@fladi
Copy link

fladi commented Jan 29, 2014

There is another module which uses the same package namespace djangular:
https://github.com/appliedsec/djangular

This is rather unpleasant as it disallows to install both packages at the same time.

@jrief
Copy link
Owner

jrief commented Jan 29, 2014

Good point, but what are the options?
I could rename the module from djangular -> ???. I'd rather prefer not having the name django inside the modules name, so django_angular is not an option. Do you have any other suggestions? Could angular by itself be a good module name?

However, I don't get the intention of djangular. It's a kind of wizard, to start projects using AngularJS. Its intention is to unload the responsibility from server-side rendering to the client, whereas the intention of my module is, to keep that in Django. In former projects, I made bad experience trying to let the client do to much of the "dirty" work, so I switched back to server side modeling/rendering/validation. Always think about Kindle users.
Moreover, I dislike the idea of having AngularJS controllers/providers/directives dynamically rendered. This makes it impossible to use tools, such as Jasmine, to write pure Javascript unit tests.

My proposal: If there are features in djangular you really like, tell me, and if they make sense, I will implement them in django-angular, doing them my way.

Jacob

@incognos
Copy link

How about "angular-dj'?

@jrief
Copy link
Owner

jrief commented Jan 29, 2014

Declined. Module names may not contain dashes, and btw. I don't like it.
Something else to consider: On PyPI my module last month hat 1603 downloads, whereas the djangular module "only" had 605. So why should I bother ~2.5 times as many users with a module renaming?

@jrief jrief closed this as completed Mar 27, 2014
@AncientSwordRage
Copy link

This feature in Django 1.7 should help resolve this without renaming anything:
https://docs.djangoproject.com/en/1.7/ref/applications/#configuring-applications

The one thing I use djangular for is getting access to the settings variables (so I can point angular at the right urls etc).

That being said, #35 is all about renaming...so....is not renaming still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants