Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the license and repo with the plugin #288

Open
mr-thierry opened this issue Dec 9, 2024 · 4 comments
Open

Package the license and repo with the plugin #288

mr-thierry opened this issue Dec 9, 2024 · 4 comments

Comments

@mr-thierry
Copy link
Contributor

We cannot use this plugin internally because one of our tool flags it because the license is not packaged with the plugin.

For example check Dexcount Gradle Plugin. The license is properly packaged in the POM:

<licenses>
    <license>
        <name>The Apache Software License, Version 2.0</name>
        <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
        <distribution>repo</distribution>
    </license>
</licenses>

There is no license in the modules-graph-assert latest POM.

Similarly, the source repo should also be included. Again, for the dexcount-gradle-plugin it's:

<scm>
    <connection>scm:git:git://github.com/KeepSafe/dexcount-gradle-plugin.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/KeepSafe/dexcount-gradle-plugin.git</developerConnection>
    <url>https://github.com/KeepSafe/dexcount-gradle-plugin/</url>
</scm>

I think by just adding vacUrl in the gradlePlugin, the license and the repo URL will be picked up automatically. See https://github.com/KeepSafe/dexcount-gradle-plugin/blob/d17e9cf40fdb6bd8f9740f2900443a660ce932a7/build.gradle#L269C1-L269C13

@mr-thierry
Copy link
Contributor Author

@mr-thierry
Copy link
Contributor Author

I'm not sure why this doesn't get picked up by the publishing task?

@brentwatson
Copy link

I think the following are missing from gradle.properties, which should resolve this:

POM_LICENCE_NAME=The Apache Software License, Version 2.0
POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt
POM_LICENCE_DIST=repo

@jraska
Copy link
Owner

jraska commented Dec 19, 2024

Hey, thanks for raising the issue. Will fix that once I get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants