We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Because of umask, calling ensureDir/ensureDirSync without fs.chmodSync, the actual mode is not the same as the intended mode. I think it is better to mention this in https://github.com/jprichardson/node-fs-extra/blob/master/docs/ensureDir.md especially for someone who is not familiar with umask.
ensureDir/ensureDirSync
fs.chmodSync
Besides, I feel it is unnecessary to call this in mkdirs.js because node will take care of that.
if (mode === undefined) { mode = o777 & (~process.umask()) }
Refer to
The text was updated successfully, but these errors were encountered:
PR welcome to clarify the docs. Thanks for the tip about explicitly doing it in the code, need to look into that.
Sorry, something went wrong.
A simple explanation of mode = 0o2775? Should it be chmod 775?
Explicit code usage fixed in #791. Still needs documented; will try to get that done.
Actually, was under the impression Node has a note about this; since they don't, not a priority to do it here.
No branches or pull requests
Because of umask, calling
ensureDir/ensureDirSync
withoutfs.chmodSync
, the actual mode is not the same as the intended mode. I think it is better to mention this in https://github.com/jprichardson/node-fs-extra/blob/master/docs/ensureDir.md especially for someone who is not familiar with umask.Besides, I feel it is unnecessary to call this in mkdirs.js because node will take care of that.
Refer to
The text was updated successfully, but these errors were encountered: