Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge ZSL patch #587

Merged
merged 8 commits into from
Dec 17, 2018
Merged

merge ZSL patch #587

merged 8 commits into from
Dec 17, 2018

Conversation

benediamond
Copy link

PR IN PROGRESS

Still to do:

  • My instructions and explanation should be moved from the top of the README into a more appropriate place.
  • The paragraph in the ZSL wiki describing the vulnerability needs to be amended / deleted.

The precise description of the patch has been removed from the main-page README. A brief description of it has been added to the [ZSL Wiki](https://github.com/jpmorganchase/quorum/wiki/ZSL), where it belongs.
@fixanoid fixanoid merged commit 8ba6534 into Consensys:zsl_geth1.6 Dec 17, 2018
fixanoid pushed a commit to Consensys/zsl-q that referenced this pull request Dec 20, 2018
Updated the README / example instructions so as to reflect the latest updates (see e.g. Consensys/quorum#587)
benediamond added a commit to Consensys/zsl-q that referenced this pull request Dec 20, 2018
Removed the paragraph regarding "the lack of a digital signature over the transaction to authenticate and prevent malleability" from the README. This paragraph also appeared in the [ZSL Wiki](https://github.com/jpmorganchase/quorum/wiki/ZSL), before it was removed.

This paragraph is no longer applicable, due to the latest PR in Quorum (Consensys/quorum#587).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants