Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Take into account Minecraft version for update checks on Fabric #135

Open
tacogerbil opened this issue May 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tacogerbil
Copy link

Describe the bug
Using MiniMOTD on Fabric 1.19.2 (Using it for Cobblemon) and the log is stating there is an update. When I go to the update sources thay all have the updates for Fabric marked as being 1.19.4.

[13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: There is an update available for MiniMOTD!
[13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: This server is running version v2.0.9, which is 3 versions outdated.
[13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: Download the latest version, v2.0.12 from GitHub at the link below:
[13:58:02] [ForkJoinPool.commonPool-worker-3/INFO]: https://github.com/jpenilla/MiniMOTD/releases/tag/v2.0.12

To Reproduce
Steps to reproduce the behavior:

  1. Boot up the server and watch the log.

Expected behavior
The mod wouldn't tell you that there is a new release for the version you are currently lrunning.

Screenshots
If applicable, add screenshots to help explain your problem.

Server Software and Version:

  • Fabric
  • 1.19.2
  • Generating server launch JAR
    Starting net.fabricmc.loader.impl.game.minecraft.BundlerClassPathCapture
    [15:24:26] [main/INFO]: Loading Minecraft 1.19.2 with Fabric Loader 0.14.21
    [15:24:26] [main/INFO]: Fabric is preparing JARs on first launch, this may take a few seconds...

Additional context
N/A

@tacogerbil tacogerbil added bug Something isn't working unconfirmed Issue not yet confirmed, needs triage labels May 31, 2023
@jpenilla jpenilla changed the title [Bug Report] This happens when another thing should have [Feature Request] Take into account Minecraft version for update checks on Fabric May 31, 2023
@jpenilla jpenilla added enhancement New feature or request and removed bug Something isn't working unconfirmed Issue not yet confirmed, needs triage labels May 31, 2023
@jpenilla
Copy link
Owner

The same thing applies as with TabTPS: jpenilla/TabTPS#30 (comment)

@salocinyeet
Copy link

salocinyeet commented Jun 25, 2024

I am running 1.20.1 Fabric

I have this same issue
Screenshot 2024-06-25 at 02 37 00
After the update
Screenshot 2024-06-25 at 02 37 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants