Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include the license file into the askalono-cli crate #38

Closed
eclipseo opened this issue Mar 28, 2019 · 5 comments
Closed

Please include the license file into the askalono-cli crate #38

eclipseo opened this issue Mar 28, 2019 · 5 comments
Labels

Comments

@eclipseo
Copy link
Contributor

It would help for packaging. Also the README and NOTICE included with the cli would help too.

@jpeddicord
Copy link
Owner

Ah! Good catch. This will probably be best served by a wrapper script to copy those into the CLI crate before publishing.

@ignatenkobrain
Copy link

it is much easier than that. Just create symlinks.

@jpeddicord
Copy link
Owner

Symlinks work if Cargo will dereference them when packaging. Does it?

Looking at rust-lang/cargo#2748 it doesn't seem to have any good symlink behavior.

@jpeddicord
Copy link
Owner

I forgot to do this in 0.4.0 just now, but I see that at least today cargo does deref symlinks! So I've added these in and will get that out in 0.4.1 (I intend on some faster release cadence, so hopefully real soon.)

@jpeddicord
Copy link
Owner

These were included in 0.4.1 as of last month. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants