triton_image: New data source #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new data source for looking up image IDs based on various search criteria.
|
LGTM, I compared code based on other providers and everything looks copacetic. I'll pull this down and try it out later. Wondering if the same thing for networks could be added for sourcing Network UUIDs from their label name. |
|
👍 @cheapRoc, that would be useful. I was also considering a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new data source for looking up Triton Image IDs based on various parameters such as name, version and so forth.
In order to get support for Image querying in the underlying SDK the vendored version has been bumped and related fixes made.