This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Fix missing signals on Windows #5056
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. /cc @piscisaureus |
|
Actually, doesn't lgtm. It is not possible to send signals on windows, so the changes to the tests are not OK. I also find out why it is broken right now. It used to work for a while during the 0.9 series, but it broke again when ea1cba6 (which was landed on the v0.8 branch only) got merged into master. |
|
Fixed in bf83251. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of libuv in node v0.10+ now supports (a few) signals on Windows.