From d9ecc64a1c2a5f5cb7455eaf0dc462b4e281b387 Mon Sep 17 00:00:00 2001
From: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
Date: Sat, 3 Aug 2024 12:44:18 +0200
Subject: [PATCH] refactor: improve API button style and behavior

By setting the button's types to "button", the `return false;` is no
longer needed.

Signed-off-by: Jo Vandeginste <Jo.Vandeginste@kuleuven.be>
---
 views/user/user_profile.html | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/views/user/user_profile.html b/views/user/user_profile.html
index a9779134..4e32ac0e 100644
--- a/views/user/user_profile.html
+++ b/views/user/user_profile.html
@@ -53,17 +53,19 @@ <h2 class="{{ IconFor `user-profile` }}">{{ i18n "Your profile" }}</h2>
                     action="{{ RouteFor `user-profile-reset-api-key` }}"
                   >
                     <button
-                      class="{{ IconFor `show` }}"
+                      type="button"
+                      class="{{ IconFor `show` }} edit"
                       title="{{ i18n `show/hide` }}"
-                      onclick="toggleTextPassword(this, 'api_key'); return false;"
+                      onclick="toggleTextPassword(this, 'api_key');"
                     />
                     <button
+                      type="button"
                       class="{{ IconFor `copy` }}"
                       title="{{ i18n `copy to clipboard` }}"
-                      onclick="copyToClipboard('api_key'); return false;"
+                      onclick="copyToClipboard('api_key');"
                     />
                     <button
-                      class="{{ IconFor `refresh` }}"
+                      class="{{ IconFor `refresh` }} dangerous"
                       title="{{ i18n `generate a new API key` }}"
                     />
                   </form>