Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyphens in sub-component names aren't highlighted for angle brackets syntax #11

Open
xtagon opened this issue May 20, 2020 · 3 comments

Comments

@xtagon
Copy link

xtagon commented May 20, 2020

Hi, just noticed that this happens for templates that use sub-components with hyphens in their name. The following example uses ember-paper to demonstrate:

<PaperForm @onSubmit={{action nextStep}} as |form|>
  <step.body>
    <p>Hello, World!</p>
  </step.body>
  <form.submit-button>
    Next
  </form.submit-button>
</PaperForm>

This syntax is valid, but form.submit-button doesn't highlight the -button part:

Annotation 2020-05-20 094157

@joukevandermaas
Copy link
Owner

This project is in "maintenance mode", which means I will accept prs that fix bugs but I probably won't make time to fix issues like this myself. In this case I think it would be relatively simple to fix the regex, so if anyone wants to do that, I'd be happy to merge a PR.

Thanks for taking the time to report this, I hope this is not too disappointing.

@xtagon
Copy link
Author

xtagon commented May 22, 2020

Thank you, I completely understand. I might take a shot at a PR later but it's not a big priority, at the end of the day it's just colors :)

@xtagon
Copy link
Author

xtagon commented Jan 2, 2022

I ended up not following up with this, or needing to. I'll leave the issue open in case someone else wants to accept it, just wanted to give an update since originally I planned a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants