Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency to @emotion/react + adopt native css solution #129

Merged
merged 11 commits into from
Apr 13, 2024

Conversation

arjunvegda
Copy link
Member

@arjunvegda arjunvegda commented Apr 2, 2024

Summary

Remaining tasks

⚠️ Warning for Mantine users

  • Using Jotai DevTools with Mantine on userland causes issues with theming on DevTools. For example, when you change the color scheme on userland to from light to dark, it will toggle Jotai DevTools' color scheme too. However, not fully. Some elements remain in light mode
  • Mantine's team is open to fixing this problem but its complex. You're welcome to take a stab at it
  • Temporary remedy for the users of Jotai DevTools is to sync their theme via props by passing computed color scheme value via props.theme

Contributors

Huge thanks to these folks for contributing this change to Jotai DevTools 🙏
@speaker-ender (#126), @WebDevMcFarland, @tori-obregon, @adamkim1006 and more!

Copy link

codesandbox-ci bot commented Apr 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@arjunvegda arjunvegda mentioned this pull request Apr 2, 2024
@arjunvegda arjunvegda marked this pull request as ready for review April 13, 2024 13:56
@arjunvegda arjunvegda merged commit 0b99ce0 into main Apr 13, 2024
3 checks passed
@arjunvegda arjunvegda deleted the fix/upgrade-mantine-v7 branch April 13, 2024 14:12
@arjunvegda arjunvegda mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with NextJs 13 and Mantine v7
1 participant