diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go index 6026d26a9b0053..fc2b58a0823f13 100644 --- a/src/cmd/dist/test.go +++ b/src/cmd/dist/test.go @@ -597,7 +597,13 @@ func (t *tester) registerTests() { t.registerTest("bench_go1", "../test/bench/go1", "go", "test", t.timeout(600), t.runFlag("")) } if t.goos != "android" && !t.iOS() { - const nShards = 5 + // Only start multiple test dir shards on builders, + // where they get distributed to multiple machines. + // See issue 20141. + nShards := 1 + if os.Getenv("GO_BUILDER_NAME") != "" { + nShards = 10 + } for shard := 0; shard < nShards; shard++ { shard := shard t.tests = append(t.tests, distTest{ @@ -1143,7 +1149,7 @@ func (t *tester) testDirTest(dt *distTest, shard, shards int) error { runtest.Do(func() { const exe = "runtest.exe" // named exe for Windows, but harmless elsewhere cmd := t.dirCmd("test", "go", "build", "-o", exe, "run.go") - cmd.Env = append(os.Environ(), "GOOS="+t.gohostos, "GOARCH="+t.gohostarch, "GOMAXPROCS=") + cmd.Env = append(os.Environ(), "GOOS="+t.gohostos, "GOARCH="+t.gohostarch) runtest.exe = filepath.Join(cmd.Dir, exe) if err := cmd.Run(); err != nil { runtest.err = err