Fix pp_type({var, ..., _}) #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'var' type variable's name is not always a string as opposed to what the comment indicate.
This commit fixes the logic to handle both cases in `pp_type`.
This commit also removes the final period in one error message because error messages don't have a
final period.
Example test that fails before this commit:
``` erlang
-module(error).
-compile([nowarn_export_all, export_all]).
-record(some_record, { id :: integer() }).
-spec error([#some_record{}]) -> [integer()].
error(List) ->
lists:map(fun(#some_record{id = Id}) -> Id end, List).
```
``` console
$ ./gradualizer error.erl
error.erl: escript: exception error: bad argument
in function io_lib:format/2
called as io_lib:format("~sThe record pattern for record #~p~s is expected to have type ~s.~n",
[[],some_record,
[32,111,110,32,108,105,110,101,32,"9",32,97,116,
32,99,111,108,117,109,110,32,"19"],
["\e[35m",'A',"\e[0m"]])
in call from gradualizer_fmt:handle_type_error/2 (src/gradualizer_fmt.erl, line 534)
in call from gradualizer_fmt:'-print_errors/2-lc$^0/1-0-'/2 (src/gradualizer_fmt.erl, line 520)
in call from gradualizer_fmt:print_errors/2 (src/gradualizer_fmt.erl, line 520)
in call from gradualizer:type_check_forms/3 (src/gradualizer.erl, line 209)
in call from gradualizer:'-type_check_files/2-fun-1-'/4 (src/gradualizer.erl, line 159)
in call from lists:foldl/3 (lists.erl, line 1267)
in call from gradualizer_cli:main/1 (src/gradualizer_cli.erl, line 14)
```
Co-authored-by: Viktor Söderqvist <viktor@zuiderkwast.se>
Co-authored-by: Radek Szymczyszyn <radoslaw.szymczyszyn@erlang-solutions.com>
|
Hmm, GH actions don't kick in... |
zuiderkwast
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test and supersedes #393. Thanks @berbiche!