Provide the git commit sha when asked for --version in CLI #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Feb 17, 2022
Makefile
Outdated
Comment on lines
58
to
59
| ebin/gradualizer.app: src/gradualizer.app.src | ebin | ||
| cp $< $@ | ||
| sed s/git/`git describe --tags --always`/ $< > $@ |
There was a problem hiding this comment.
Isn't it risky to replace all occurences of "git"? What if we add these three letters somewhere else in the app file?
Maybe sed 's/{vsn, *"git"}/{vsn, `git describe --tags --always`}/' is more safe..? (I don't know what rebar3 and erlang.mk does, but I suppose at least rebar3 parses the file and replaces only this occurrence.)
There was a problem hiding this comment.
Good point, it definitely doesn't hurt to make the pattern more specific 👍
zuiderkwast
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.