Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Some compare function are not exported #349

Closed
yjhmelody opened this issue Aug 27, 2021 · 2 comments · Fixed by #404
Closed

Some compare function are not exported #349

yjhmelody opened this issue Aug 27, 2021 · 2 comments · Fixed by #404
Labels
enhancement An improvement to an existing feature good first issue Good for newcomers

Comments

@yjhmelody
Copy link
Contributor

yjhmelody commented Aug 27, 2021

I want to directly use specific types of comparison functions, such as boolean::compare, but I found that they are not exported.
But their scalar version such as boolean_compare_scalar are exported.

Should we make the following mods be pub?

mod boolean;
mod primitive;
mod utf8;
pub mod boolean;
pub mod primitive;
pub mod utf8;
@jorgecarleitao
Copy link
Owner

Thanks! fire it away :) Could give it a quick look to make sure that they are documented? The mod would probably also benefit from a docstring on the top to denote that they are for.

@yjhmelody
Copy link
Contributor Author

Some of them are undocumented, some are, and so are the scalar versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants