forked from w3tecch/typeorm-seeding
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove context from factories #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE Context is being removed from factories. This could break some applications that were using it
github-actions bot
pushed a commit
that referenced
this pull request
Jan 3, 2022
# [3.0.0-next.1](v2.0.0...v3.0.0-next.1) (2022-01-03) ### Bug Fixes * adapt seeder to new schema ([a1d4e27](a1d4e27)) * remove factories option from config ([870a23d](870a23d)) ### chore * remove all faker usages from source folder ([2e4b0fb](2e4b0fb)) * remove faker from dependencies ([f41cef4](f41cef4)) ### Features * adapt use seeders to new structure ([7ea3607](7ea3607)) * move factory definition to new abstract class ([41cf349](41cf349)) * remove context from factories ([#23](#23)) ([c030e89](c030e89)) * remove deprecated elements ([09006e8](09006e8)) * remove factory helper methods and test associateds ([#30](#30)) ([a335ca2](a335ca2)) * remove useFactories helper method ([#29](#29)) ([6fbeaba](6fbeaba)) * seed command will execute now default seeder or seed param ([84025f9](84025f9)) ### BREAKING CHANGES * `useSeeders` change its definition and is now incompatible with previous version * Faker is not available anymore as function param * Faker is removed from dependencies and now users must install it by themselves * Some of these functions were used on previous versions * New abstract factory class is incompatible with previous version * Helper methods removed were a core part of previous versions * This method will no longer be available as is useless in new architecture * Context is being removed from factories. This could break some applications that were using it
🎉 This PR is included in version 3.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jorgebodega
added a commit
that referenced
this pull request
Jan 6, 2022
BREAKING CHANGE Context is being removed from factories. This could break some applications that were using it
jorgebodega
pushed a commit
that referenced
this pull request
Jan 6, 2022
# [3.0.0-next.1](v2.0.0...v3.0.0-next.1) (2022-01-03) ### Bug Fixes * adapt seeder to new schema ([a1d4e27](a1d4e27)) * remove factories option from config ([870a23d](870a23d)) ### chore * remove all faker usages from source folder ([2e4b0fb](2e4b0fb)) * remove faker from dependencies ([f41cef4](f41cef4)) ### Features * adapt use seeders to new structure ([7ea3607](7ea3607)) * move factory definition to new abstract class ([41cf349](41cf349)) * remove context from factories ([#23](#23)) ([c030e89](c030e89)) * remove deprecated elements ([09006e8](09006e8)) * remove factory helper methods and test associateds ([#30](#30)) ([a335ca2](a335ca2)) * remove useFactories helper method ([#29](#29)) ([6fbeaba](6fbeaba)) * seed command will execute now default seeder or seed param ([84025f9](84025f9)) ### BREAKING CHANGES * `useSeeders` change its definition and is now incompatible with previous version * Faker is not available anymore as function param * Faker is removed from dependencies and now users must install it by themselves * Some of these functions were used on previous versions * New abstract factory class is incompatible with previous version * Helper methods removed were a core part of previous versions * This method will no longer be available as is useless in new architecture * Context is being removed from factories. This could break some applications that were using it
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
# [3.0.0](v2.0.0...v3.0.0) (2022-01-06) ### Bug Fixes * adapt seeder to new schema ([aecf7b4](aecf7b4)) * remove factories option from config ([d66f0f1](d66f0f1)) ### chore * remove all faker usages from source folder ([1e14718](1e14718)) * remove faker from dependencies ([40f21c8](40f21c8)) ### Features * adapt use seeders to new structure ([5bca471](5bca471)) * move factory definition to new abstract class ([81ccdf6](81ccdf6)) * remove context from factories ([#23](#23)) ([b7ecba4](b7ecba4)) * remove deprecated elements ([d09e154](d09e154)) * remove factory helper methods and test associateds ([#30](#30)) ([3393724](3393724)) * remove useFactories helper method ([#29](#29)) ([ddb5c2f](ddb5c2f)) * seed command will execute now default seeder or seed param ([314d8c3](314d8c3)) ### BREAKING CHANGES * `useSeeders` change its definition and is now incompatible with previous version * Faker is not available anymore as function param * Faker is removed from dependencies and now users must install it by themselves * Some of these functions were used on previous versions * New abstract factory class is incompatible with previous version * Helper methods removed were a core part of previous versions * This method will no longer be available as is useless in new architecture * Context is being removed from factories. This could break some applications that were using it
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2022
# [4.0.0-next.1](v3.0.0...v4.0.0-next.1) (2022-01-08) ### Bug Fixes * adapt seeder to new schema ([a1d4e27](a1d4e27)) * add rimraf as dev dependency ([6be6801](6be6801)) * remove factories option from config ([870a23d](870a23d)) ### chore * remove all faker usages from source folder ([2e4b0fb](2e4b0fb)) * remove faker from dependencies ([f41cef4](f41cef4)) ### Features * adapt use seeders to new structure ([7ea3607](7ea3607)) * move factory definition to new abstract class ([41cf349](41cf349)) * remove context from factories ([#23](#23)) ([c030e89](c030e89)) * remove deprecated elements ([09006e8](09006e8)) * remove factory helper methods and test associateds ([#30](#30)) ([a335ca2](a335ca2)) * remove useFactories helper method ([#29](#29)) ([6fbeaba](6fbeaba)) * seed command will execute now default seeder or seed param ([84025f9](84025f9)) ### BREAKING CHANGES * `useSeeders` change its definition and is now incompatible with previous version * Faker is not available anymore as function param * Faker is removed from dependencies and now users must install it by themselves * Some of these functions were used on previous versions * New abstract factory class is incompatible with previous version * Helper methods removed were a core part of previous versions * This method will no longer be available as is useless in new architecture * Context is being removed from factories. This could break some applications that were using it
🎉 This PR is included in version 4.0.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE Context is being removed from factories. This could break some applications that were using it