Extract ASGI scope creation into function

[ediskandarov]

• Simplify magnum call function
• extract event processing into dedicated functions

This is a required abstraction to create non-AWS event handlers.

[jordaneremieff]

Thanks for the PR @emcpow2. There is an issue here related to custom scope resolution that should also be considered when making a change like this, and I think if we decide to go with non-AWS event handling that will take some additional design consideration later as well.

I'm going to close this because there is some investigation to do before we start extracting logic from the main adapter method.

[ediskandarov]

Thit PR does not introduce any complexity regarding the path resolution issue.

Instead, the code looks cleaner and easier to test and to introduce new changes.

Please consider reopening the PR.

[jordaneremieff]

@emcpow2 I don't disagree with your approach generally, and I've actually thought we should do something like this for awhile now. However, I've held off on these kind of changes because once we introduce new public API then users will start relying on it in ways that conflict with other things we might want to do. This is the same reason I left the linked issue open because the design needs careful consideration.

[jordaneremieff]

@emcpow2 I've taken the time to think about this some more - let's go ahead with it. I'll reopen and do a small review of some adjustments, but otherwise this should be fine to do now. Thanks.

[jordaneremieff]

Just a few small things then I think this will be good to merge. The most significant change request is to remove the separate method for handling the initial body (we can look at this as a separate issue later).

[ediskandarov]

thanks. Done

[jordaneremieff]

Looks good, thanks!