-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELB Support / Fix: APIGW v2 cookies response #155
ELB Support / Fix: APIGW v2 cookies response #155
Conversation
Hi @araki-yzrh, thanks for the PR! I'll try to get to reviewing this soon and update the PR with any comments. |
Hey @araki-yzrh! Sorry, my review has been a bit delayed, it might be a bit longer before I'm able to look this over. My personal life has been pretty demanding lately, but I do intend to review this when I find some good time. |
Anecdotally I can say this PR works as expected. I recently installed this fork of Mangum for a POC deploying Django on AWS lambda using ELB as the trigger and things seem to be working as expected. Thank you @araki-yzrh and @jordaneremieff for working on this! |
Worked here too. Installed the Mangum fork on FastAPI as dependency and deployed to AWS Lambda using ELB. Thanks for the fork work. |
@araki-yzrh great work, thanks! |
* fix apigw v2 request cookie header * add v1 cookie header test * support elb * support elb test * refactored adapter event parsing * fix elb single value headers response * fix apigw v2 cookie response * remove old code
* fix apigw v2 request cookie header * add v1 cookie header test * support elb * support elb test * refactored adapter event parsing * fix elb single value headers response * fix apigw v2 cookie response * remove old code
* fix apigw v2 request cookie header * add v1 cookie header test * support elb * support elb test * refactored adapter event parsing * fix elb single value headers response * fix apigw v2 cookie response * remove old code
Issue: #149
Hi.
im added ELB support code and tests.
and support APIGW v2 cookies response
see also: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html
ELB has two modes.
Single Value Mode
request event
response object
Multi Value Mode
request event
response object
Support APIGW v2 cookies response
see also: https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html
response object