Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] Add PKCS8 Private Key Support on PKI Issue. #61

Closed
grrolland opened this issue Jun 5, 2024 · 2 comments
Closed

[IMPROVEMENT] Add PKCS8 Private Key Support on PKI Issue. #61

grrolland opened this issue Jun 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@grrolland
Copy link

grrolland commented Jun 5, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
When issuing private key from PKI, the format of the private key is, by default PKCS1. PKCS1 is badly supported by java. It would be nice to support the PKCS8 format since vault support it.

Describe the solution you'd like
When calling pki.issue, add parameter to specify private key format

Additional context
Vault PKI support this since 0.9.0 : hashicorp/vault#3518
@grrolland grrolland added the enhancement New feature or request label Jun 5, 2024
@grrolland grrolland mentioned this issue Jun 5, 2024
Merged
@henryx
Copy link
Collaborator

henryx commented Jun 6, 2024

Thank you for the PR, I'll viewed it and I appreciate your work. ASAP I'll release new version with this PR

@henryx henryx closed this as completed Jun 6, 2024
@grrolland
Copy link
Author

Many thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@henryx @grrolland